-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preview-service): install chromium browser as a dependency at build time not runtime #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails on arm64 apple with
|
iainsproat
changed the title
fix(preview-service): install chromium browser as a dependency
fix(preview-service): install chromium browser as a dependency at build time not runtime
Jun 18, 2024
iainsproat
changed the title
fix(preview-service): install chromium browser as a dependency at build time not runtime
feat(preview-service): install chromium browser as a dependency at build time not runtime
Jun 18, 2024
Works with:
Executing into the running container, the executable works at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Currently pupeeteer will download its own version of Chromium. This slows startup time when puppeteer is run, and consumes network bandwidth.
This is unnecessary if chromium is installed on the image and puppeteer configured to use the existing installed version
This PR also tidies up the DockerFile to install chromium using its package rather than installing all dependencies individually.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References