Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE2 - Visual improvements from pairing with Agi #2111

Merged
merged 10 commits into from
Mar 12, 2024
Merged

FE2 - Visual improvements from pairing with Agi #2111

merged 10 commits into from
Mar 12, 2024

Conversation

andrewwallacespeckle
Copy link
Contributor

Description & motivation

At the retreat, I paired with Agi on some outstanding visual bugs/improvements. This PR is mainly tailwind changes, although there are a couple of larger changes listed below.

Changes:

  • Scrollbar - Now the scrollbar track will always be visible, except on the Viewer. This is to stop the constant layout shifts as the scrollbar appears/disappears.
  • Add new Versions Icon and replace existing HeroIcons Icon.
  • There was a transition on the "Reset Filters" button, but it didn't work. I replaced with a new transition.
  • Added Title to Filters Panel
  • Tidied up Object Type List/Search
  • "View Changes" is always visible now
  • Added Sunlight Shadows toggle to light panel
  • Added new Prop to FormSwitch, so the icons can be disabled.

Screenshots:

image image image image

@andrewwallacespeckle andrewwallacespeckle marked this pull request as ready for review March 12, 2024 10:43
fabis94
fabis94 previously approved these changes Mar 12, 2024
View reviewed changes
@andrewwallacespeckle andrewwallacespeckle merged commit 84a485d into main Mar 12, 2024
30 of 31 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/fe2-visual-improvements-pair-with-agi branch March 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewwallacespeckle @fabis94