Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breadcrumbs to discussions and models. Temp change to routing #2123

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add breadcrumbs to discussions and models. Temp change to routing #2123

merged 2 commits into from
Mar 13, 2024

Conversation

andrewwallacespeckle
Copy link
Contributor

Changes:

  • Update projectDiscussionsRoute & allProjectModelsRoute so they go to project page. This is temporary until the Tab routing is done.
  • Add breadcrumbs to both models and discussions page, incase someone has a bookmark saved, they can still use breadcrumbs to navigate.

@andrewwallacespeckle andrewwallacespeckle marked this pull request as ready for review March 13, 2024 15:08
benjaminvo
benjaminvo approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@benjaminvo benjaminvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But I wonder if we could just redirect the All models and All discussions pages to go to the projectDiscussionsRoute and allProjectModelsRoute on load?

Can be a follow up improvement if you want to merge this. This is also fine for now.

@andrewwallacespeckle andrewwallacespeckle merged commit dfa340a into main Mar 13, 2024
30 of 34 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/update-allProjectsModelsRoute-to-project-page branch March 13, 2024 15:26
@andrewwallacespeckle andrewwallacespeckle restored the andrew/update-allProjectsModelsRoute-to-project-page branch April 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminvo benjaminvo benjaminvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewwallacespeckle @benjaminvo