Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw range error fix #2138

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Draw range error fix #2138

merged 3 commits into from
Mar 19, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Fix for issues with draw ranges for more complex combination of filters. Current state to act as a patch. Several aspects of our batch implementations need a bit of attention

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Mar 14, 2024
@AlexandruPopovici AlexandruPopovici marked this pull request as ready for review March 15, 2024 09:39
@benjaminvo benjaminvo requested review from fabis94 and removed request for benjaminvo and didimitrie March 19, 2024 10:30
@AlexandruPopovici AlexandruPopovici merged commit 74ffb45 into main Mar 19, 2024
10 of 14 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/draw-range-fix branch March 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants