Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace YouTube video with Vimeo #2152

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

andrewwallacespeckle
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle commented Mar 21, 2024

Description & motivation

It was decided that pro Vimeo was worth the cost, as it gave us the option of a much cleaner embedded player. The first video we have moved to Vimeo is the "What's new in Speckle" video.

Changes:

  • Replace FE1 YouTube link with Vimeo Embed
  • Replace FE2YouTube link with Vimeo Embed
  • Added a background div with spinner, which will show while the video loads

Screenshots:

fe1.mov
fe2.mov

@andrewwallacespeckle andrewwallacespeckle marked this pull request as ready for review March 21, 2024 11:54
@andrewwallacespeckle andrewwallacespeckle merged commit a489a7b into main Mar 21, 2024
32 of 33 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/replace-youtube-with-vimeo branch March 21, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants