Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe2): trim spaces around slashes in model names #2264

Conversation

andrewwallacespeckle
Copy link
Contributor

Description & motivation

There was a bug where having a space before or after the "/" would cause moving/creating models to fail. It created a folder for the model, but the folder had no models.

Changes:

  • Added new helper function called sanitizeModelName
  • Anywhere the user can edit the Model Name (or add a new one), this function is called to remove any spaces around the slash

Copy link

linear bot commented May 16, 2024

@andrewwallacespeckle andrewwallacespeckle marked this pull request as ready for review May 16, 2024 10:50
Copy link
Contributor

@benjaminvo benjaminvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@andrewwallacespeckle andrewwallacespeckle merged commit 39c2202 into main May 23, 2024
20 of 23 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/web-900-nested-model-not-outputted-in-list-view branch May 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants