feat(fe2): change submit logic for access settings before embedding #2278
+94
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…systems/speckle-server into fabians/fe2-automate-integration
…ms/speckle-server into gergo/automateBackendModule
…klesystems/speckle-server into gergo/automateBackendModule
…s-settings-before-embedding
…s-settings-before-embedding
|
Everything works fine! Some design feedback: Let's only show the copy "To change this setting [...]" if you're not the owner + let's output it below the select input instead which I assume will be disabled. I don't have a private project where I'm not an owner so I can't test this.
|
benjaminvo
requested changes
May 23, 2024
…s-settings-before-embedding
|
|
@andrewwallacespeckle Maybe I wasn't clear. I want the blue alert to always say "Model embedding does not work [...]". And then under the select input write the text "To change this setting [...]" if user is not Owner. And btw that copy can be shortened to "You must be an Owner of this project to change this setting". |
|
Sorry, I misread your comment. Now, when you are not an owner: And when you are an owner: |
andrewwallacespeckle
deleted the
andrew/web-878-change-submit-logic-for-access-settings-before-embedding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Previously, when you tried to embed a Private project, you would be greeted with a Dialog warning that this was not possible, and a select which allowed you to change the project access (if you are an owner).
This updated instantly, so as soon as you selected "Public", the project was updated.
This has been changed, and a save button introduced. Now, when you change Status the Save button will be enabled, allowing the user to save.