feat: ensure consistent ordering of nodes to match ViewerLayoutPanel #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewwallacespeckle I don't completely understand this sorting: "Model w/ version > Model > Folder name > Object ID". Can you explain? |
I'm not entirely sure why this was order was chosen, but it is very intentional. There is even a comment about it: We can easily update this, but I'd assume that order was chosen for a reason. This PR uses the same ordering method in Scene Explorer to replicate Models order. |
fabis94
requested changes
May 27, 2024
|
Latest changes made on pairing call with @fabis94 |
fabis94
previously approved these changes
Jun 19, 2024
fabis94
approved these changes
Jun 21, 2024
andrewwallacespeckle
deleted the
andrew/web-899-sort-models-and-scene-explorer-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Currently, in the viewer, the Model panel has a different ordering to the Scene Explorer. This task aims to correct this by ordering Scene Explorer as Model panel currently is:
Model w/ version > Model > Folder name > Object ID
Changes
Correctly classify and order nodes into versionNodes, modelNodes, folderNodes, allModelNodes, and objectNodes