-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a raw data viewer for advanced users #2296
Conversation
Really nice @didimitrie! I think we're close to something we can release but I have some suggestions for how we can improve it both now + in a follow up PR. Do now
Follow up
@andrewwallacespeckle Happy to collaborate with you on this today |
I should have some time today to implement this. Let's ping each other if you or @andrewwallacespeckle get to it first! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions, but great work!
@@ -28,6 +28,17 @@ | |||
Isolate | |||
</div> | |||
</FormButton> | |||
<div class="w-full text-right"> | |||
<FormButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a tooltip here? @benjaminvo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't see this comment. Yes I agree! But let's just follow up with that and merge this now so we don't need to wait for the CI checks again.
@benjaminvo is keen to get this out this week, so I am going to start making some these changes. I'll be at my desk in Gather if anyone wants to help |
I've made the changes suggested by Benjamin, and left a few suggestions. Will wait for Dim before going any further |
Changelog:
TODOs:
Screen caps: