Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a raw data viewer for advanced users #2296

Merged
merged 29 commits into from
May 30, 2024
Merged

adds a raw data viewer for advanced users #2296

merged 29 commits into from
May 30, 2024

Conversation

didimitrie
Copy link
Member

@didimitrie didimitrie commented May 29, 2024

Changelog:

  • adds a raw data viewer, similar to FE1's - but a bit more "raw" - ie, no cosmetics are applied on property names or values anywhere
  • adds "open in new window" for object selection

TODOs:

  • fix array key indexing for object properties
  • fix null props (string vs. array)
  • fix loaded resources tabs for objects loaded only scenario
  • fix raw data viewer for objects loaded only scenario

Screen caps:

image

image

image

@didimitrie didimitrie marked this pull request as ready for review May 29, 2024 15:31
@benjaminvo
Copy link
Contributor

Really nice @didimitrie! I think we're close to something we can release but I have some suggestions for how we can improve it both now + in a follow up PR.

Do now

  • Keep Scene Explorer title bar in both states.
    • Dev mode toggle button has on/off state
    • Unfold/collapse buttons can be disabled in dev mode if they do nothing
  • Remove the big blue button. Rely on the button in the title bar to turn dev mode on and off.

Follow up

  • Reuse the scene explorer's tree view in dev mode, so we give the feeling that it's the same component but you're just showing/hiding data. The styling can be more compressed in dev mode.

@andrewwallacespeckle Happy to collaborate with you on this today

CleanShot 2024-05-30 at 06 33 52@2x

@didimitrie
Copy link
Member Author

Really nice @didimitrie! I think we're close to something we can release but I have some suggestions for how we can improve it both now + in a follow up PR.

Do now

  • Keep Scene Explorer title bar in both states.
    • Dev mode toggle button has on/off state
    • Unfold/collapse buttons can be disabled in dev mode if they do nothing
  • Remove the big blue button. Rely on the button in the title bar to turn dev mode on and off.

Follow up

  • Reuse the scene explorer's tree view in dev mode, so we give the feeling that it's the same component but you're just showing/hiding data. The styling can be more compressed in dev mode.

@andrewwallacespeckle Happy to collaborate with you on this today

CleanShot 2024-05-30 at 06 33 52@2x

I should have some time today to implement this. Let's ping each other if you or @andrewwallacespeckle get to it first!

Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, but great work!

packages/frontend-2/components/viewer/dataviewer/Row.vue Outdated Show resolved Hide resolved
@@ -28,6 +28,17 @@
Isolate
</div>
</FormButton>
<div class="w-full text-right">
<FormButton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a tooltip here? @benjaminvo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see this comment. Yes I agree! But let's just follow up with that and merge this now so we don't need to wait for the CI checks again.

@andrewwallacespeckle
Copy link
Contributor

@benjaminvo is keen to get this out this week, so I am going to start making some these changes. I'll be at my desk in Gather if anyone wants to help

@andrewwallacespeckle
Copy link
Contributor

@benjaminvo is keen to get this out this week, so I am going to start making some these changes. I'll be at my desk in Gather if anyone wants to help

I've made the changes suggested by Benjamin, and left a few suggestions. Will wait for Dim before going any further

@benjaminvo
Copy link
Contributor

I just updated the styling and copy a bit. I've called it Dev Mode but let me know if you don't like that! I'm actually not really sure I like it.

CleanShot 2024-05-30 at 13 25 51@2x

@benjaminvo benjaminvo merged commit 3c15e88 into main May 30, 2024
20 of 22 checks passed
@benjaminvo benjaminvo deleted the dim/prop-viewer branch May 30, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants