Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickerless Depth Texture Read #2300

Merged
merged 4 commits into from
May 31, 2024
Merged

Flickerless Depth Texture Read #2300

merged 4 commits into from
May 31, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Added a new extension that reads the depth texture from the framebuffer and avoids the annoying flicker of the canvas of the regular screenshot function that's currently being used for gendo. Key ideas are:

  • No changes in the viewer library
  • No flickering

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

didimitrie
didimitrie previously approved these changes May 30, 2024
Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@AlexandruPopovici AlexandruPopovici merged commit cd5a8b9 into main May 31, 2024
20 of 22 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/texture-read branch May 31, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants