Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if user is fn author w/ exec engine #2310

Merged
merged 1 commit into from
May 31, 2024
Merged

feat: check if user is fn author w/ exec engine #2310

merged 1 commit into from
May 31, 2024

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented May 31, 2024

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@linear Linear
Copy link

linear bot commented May 31, 2024

WEB-1036 Backend needs to proxy the request to the execution engine

gjedlicska
gjedlicska requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@gjedlicska gjedlicska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix the redirect path

This will be part of another PR.

packages/frontend-2/components/automate/function/CreateDialog.vue Show resolved Hide resolved
@fabis94 fabis94 requested a review from gjedlicska May 31, 2024 13:00
@fabis94 fabis94 merged commit 7c68543 into main May 31, 2024
20 of 22 checks passed
@fabis94 fabis94 deleted the fabians/web-1036 branch May 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainsproat iainsproat Awaiting requested review from iainsproat

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabis94 @gjedlicska