feat(objs): adds feature flag for no closure writing - patch for large object sending #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didimitrie
changed the title
gjedlicska
requested changes
Jun 17, 2024
| for (const batch of batches) { | ||
| prepInsertionObjectBatch(batch) | ||
| await Objects().insert(batch).onConflict().ignore() | ||
| servicesLogger.info(`Inserted ${batch.length} objects`) |
There was a problem hiding this comment.
servicesLogger.info({batchLength: batch.length }, 'Inserted {batchLength} objects')
There was a problem hiding this comment.
I think this should be 'Inserted {batchSize} objects'
There was a problem hiding this comment.
Changed, thanks both!
iainsproat
reviewed
Jun 17, 2024
| expect(res).to.have.status(400) | ||
| expect(res.text).contains('Object too large') | ||
| }) | ||
| // it('Should not allow upload with invalid body (object too large)', async () => { |
There was a problem hiding this comment.
Would have preferred an it.skip or equivalent, so we're aware we're skipping a test.
Would have been better to make this test continue to work, perhaps by deploying a server with an artificially reduced threshold.
There was a problem hiding this comment.
That's why i commented out - happy to "skip" it in a proper way later down the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR after this investigation is that simply not writing to closures might be a very good simple patch.
Note this PR also defaults the max object size to 100 (a 10x increase) in case it's not specified otherwise from the env.