WEB-1096: DataDog Errors #2409
Merged
WEB-1096: DataDog Errors #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabis94
requested changes
Jun 20, 2024
| } | ||
| return this.promisifyIdbRequest(store.transaction) | ||
| } catch (e) { | ||
| this.logger.error(e) |
There was a problem hiding this comment.
There's no longer a return in the function in the error scenario. Even if undefined/void is fine, we should be explicit about it.
fabis94
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Complete information in https://linear.app/speckle/issue/WEB-1096/clean-up-viewer-errors#comment-5f5a5b63
This PR fixes part of the reported errors, however for the remaining I could not find a way to replicate and there is a good chance that they are caused by data anomalies in speckle streams, in which case we need the actual data associated with the data dog report in order to be able to reproduce
Changes:
findIdwith undefined or null id now returns nullTo-do before merge:
Screenshots:
Validation of changes:
Checklist:
References