Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preview-service): remove SYS_ADMIN capability requirement #2414

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat(preview-service): remove SYS_ADMIN capability requirement #2414

merged 2 commits into from
Jun 20, 2024

Conversation

iainsproat
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat changed the title fix(preview-service): avoid SYS_ADMIN capabilities feat(preview-service): avoid SYS_ADMIN capabilities Jun 20, 2024
@iainsproat iainsproat marked this pull request as ready for review June 20, 2024 13:32
@iainsproat iainsproat changed the title feat(preview-service): avoid SYS_ADMIN capabilities feat(preview-service): remove SYS_ADMIN capability requirement Jun 20, 2024
@iainsproat iainsproat merged commit 69757fb into main Jun 20, 2024
24 of 25 checks passed
@iainsproat iainsproat deleted the iain/preview-service-revert-to-previous-settings branch June 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iainsproat