Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/auth): database errors result in 500 status code #2731

Merged
merged 4 commits into from
Aug 22, 2024
Merged

fix(server/auth): database errors result in 500 status code #2731

merged 4 commits into from
Aug 22, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Aug 22, 2024 •
edited
Loading

  • previously 401 were returned which resulted in connectors not retrying

Description & motivation

Resolves https://linear.app/speckle/issue/WEB-1685/database-failures-should-result-in-5xx-status-code-not-4xx

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review August 22, 2024 13:33
@iainsproat iainsproat requested a review from gjedlicska August 22, 2024 13:33
@gjedlicska gjedlicska merged commit 6715a03 into main Aug 22, 2024
22 of 24 checks passed
@gjedlicska gjedlicska deleted the iain/database-errors-result-in-500-errors branch August 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjedlicska gjedlicska gjedlicska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iainsproat @gjedlicska