feat(fe2): Align workspace member tables with designs #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikehrn
approved these changes
Aug 27, 2024
andrewwallacespeckle
deleted the
andrew/web-1560-align-table-component-with-new-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Remove buttons from Members tables, and move them to a context menu.
This change involved adding mount-menu-on-body functionality to LayoutMenu. I hade to go through and update each LayoutMenu to make sure they were sitting correctly after this, so there are some changed files with minimal changes.
Follow up task
Move Role select to new dialog
https://linear.app/speckle/issue/WEB-1719/move-role-select-from-members-table