Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plus CTA to SidebarGroup #2776

Merged

Conversation

andrewwallacespeckle
Copy link
Contributor

Description & motivation

Move the "Add Workspace" button to the LayoutSidebarGroup, as per the designs.

image

Copy link

linear bot commented Aug 27, 2024

Copy link
Contributor

@Mikehrn Mikehrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) We will also need to enable it in the settings sidebar tho

@andrewwallacespeckle
Copy link
Contributor Author

Looks good :) We will also need to enable it in the settings sidebar tho

The designs showed the "+" in the main sidebar, but the button in the settings sidebar. I wasn't sure if this was a mistake in the Figma or not, so I'm going to check with Michal tomorrow.

@Mikehrn
Copy link
Contributor

Mikehrn commented Aug 27, 2024

Looks good :) We will also need to enable it in the settings sidebar tho

The designs showed the "+" in the main sidebar, but the button in the settings sidebar. I wasn't sure if this was a mistake in the Figma or not, so I'm going to check with Michal tomorrow.

In that case ignore my comment :) I think in settings it will be still nice to have also as a plus (the sidebar gets quite full), but we can follow up on that later if we wanna change that

@andrewwallacespeckle andrewwallacespeckle merged commit e9c112f into main Aug 28, 2024
22 of 24 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/web-1723-move-new-workspace-to-sidebargroup branch August 28, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants