Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspaces): dont leak guests #2819

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

gjedlicska
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

linear bot commented Aug 29, 2024

@gjedlicska
Copy link
Contributor Author

@alemagio for your retroactive review too, we were leaking guests between workspaces, if the user had a member role on wsA and a guest role on wsB, they would show up as both a guest and a member on wsA billing

@gjedlicska gjedlicska merged commit 0d6bb3a into main Aug 29, 2024
22 of 24 checks passed
@gjedlicska gjedlicska deleted the gergo/web-1763-workspace-billing-guests-leak branch August 29, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants