chore(server): apollo server v3 -> v4 #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabis94
requested review from
gjedlicska,
cdriesler,
iainsproat and
alemagio
fabis94
commented
Sep 5, 2024
| ApolloServer, | ||
| ForbiddenError, | ||
| ApolloServerExpressConfig, | ||
| ApolloError |
There was a problem hiding this comment.
Apollo's ApolloError & ForbiddenError no longer exist
fabis94
commented
Sep 5, 2024
| @@ -55,7 +55,7 @@ const cleanup = async () => { | |||
| } | |||
|
|
|||
| describe('Stream access requests', () => { | |||
| let apollo: ApolloServer | |||
| let apollo: ServerAndContext | |||
There was a problem hiding this comment.
Biggest annoyance - Apollo Server instance is no longer associated w/ the context builder, its now fed into the express middleware instead. When running operations against it manually, the context value has to be passed into the execute() call
fabis94
commented
Sep 5, 2024
| import { Nullable } from '@speckle/shared' | ||
| import { UserInputError } from 'apollo-server-errors' |
There was a problem hiding this comment.
UserInputError no longer exists
iainsproat
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were many breaking changes in this one, the most annoying one being that the context builder function is no longer associated with the ApolloServer instance
also had to update graphql 15 -> 16
i tested out server (& tests), frontend 2 and frontend, tried out both normal operations and subscriptions - all seemed to work