Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismissable invite banners for discoverable workspaces #2892

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Dismissable invite banners for discoverable workspaces #2892

merged 4 commits into from
Sep 9, 2024

Conversation

cdriesler
Copy link
Member

Description & motivation

  • Workspace discovery can lead to a lot of creative implied invites. And you can't dismiss them. We find this silly

Changes:

  • Adds dismiss button which, for now, persists the choice with cookies
  • Changes action labels for discoverable workspaces, but preserves them for workspace invites:
workspace-invites

Mikehrn
Mikehrn previously approved these changes Sep 6, 2024
View reviewed changes
@andrewwallacespeckle
Copy link
Contributor

I made some changes to the Banner yesterday, let me know if you have any issues with the merge @cdriesler

@cdriesler cdriesler merged commit d06f443 into main Sep 9, 2024
23 of 25 checks passed
@cdriesler cdriesler deleted the charles/cookies branch September 9, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikehrn Mikehrn Mikehrn approved these changes

@andrewwallacespeckle andrewwallacespeckle Awaiting requested review from andrewwallacespeckle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdriesler @andrewwallacespeckle @Mikehrn