Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): cross-server-sync IoC Part 2 #2907

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Sep 9, 2024

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@@ -34,6 +47,23 @@ const command: CommandModule<
}
},
handler: async (argv) => {
const downloadProject = downloadProjectFactory({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope we get a DI container soon haha, writing these out physically hurts

@fabis94 fabis94 merged commit f53bdd6 into main Sep 9, 2024
23 of 25 checks passed
@fabis94 fabis94 deleted the fabians/cross-server-sync-ioc-2 branch September 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants