Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add filter for workspace members table #2917

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Feat: add filter for workspace members table #2917

merged 5 commits into from
Sep 10, 2024

Conversation

Mikehrn
Copy link
Contributor

@Mikehrn Mikehrn commented Sep 10, 2024

Add filter to workspace members table to filter on role

Screenshot 2024-09-10 at 10 00 18

@linear Linear
Copy link

linear bot commented Sep 10, 2024

WEB-1854 Frontend

andrewwallacespeckle
andrewwallacespeckle requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but there is a slight alignment bug:
image

The select seems to be 34px, but the search is only 32px.

@andrewwallacespeckle
Copy link
Contributor

Code looks

The code looks good, but there is a slight alignment bug: image

The select seems to be 34px, but the search is only 32px.

Also a slight difference in the non-active or hovered border colour

@Mikehrn Mikehrn merged commit cf3a948 into main Sep 10, 2024
23 of 25 checks passed
@Mikehrn Mikehrn deleted the mike/web-1854-frontend branch September 10, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwallacespeckle andrewwallacespeckle andrewwallacespeckle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikehrn @andrewwallacespeckle