fix(server/previews): fix factory method which require getStreams as parameter #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert javascript to typescript
iainsproat
commented
Sep 27, 2024
| @@ -50,7 +50,7 @@ exports.init = (app, isInitial) => { | |||
| getPreviewImage: getPreviewImageFactory({ db }) | |||
| }) | |||
| const sendObjectPreview = sendObjectPreviewFactory({ | |||
| getObject, | |||
| getStream, | |||
There was a problem hiding this comment.
This was the culprit for the 5XX errors.
iainsproat
changed the title
gjedlicska
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
We were receiving a higher than normal number of 5XX errors from the
/preview/*endpoints on the server.A 500 error can be recreated by requesting a url parameter of
?postprocess=og.This was due to an invalid factory parameter being passed to the method.
Changes:
packages/server/modules/preview/index.jsandpackages/server/modules/previews/ogImage.jsto typescript, this aids in catching this category of type mismatch error.getObjectwithgetStream, as the latter is required by thesendObjectPreviewFactorymethod.SendObjectPreviewparameter forangleto be undefinedTo-do before merge:
Screenshots:
Validation of changes:
It now works after the fix:
Checklist:
References