Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gergo/web 1926 test app api #3166

Merged
merged 7 commits into from
Oct 1, 2024
Merged

gergo/web 1926 test app api #3166

merged 7 commits into from
Oct 1, 2024

Conversation

gjedlicska
Copy link
Contributor

  • feat(workspaces): add workspace sso feature flag
  • feat(workspaceSso): wip validate sso
  • feat(workspaces): validate and add sso provider to the workspace with user sso sessions

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

linear bot commented Oct 1, 2024

WEB-1926 Test app api

Copy link

gitguardian bot commented Oct 1, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13992127 Triggered Generic High Entropy Secret 29d6bdc packages/server/validateOidc.js View secret
13992127 Triggered Generic High Entropy Secret 6149b9e packages/server/validateOidc.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

cdriesler
cdriesler previously approved these changes Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

📸 Preview service has generated an image.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

📸 Preview service has generated an image.

@cdriesler cdriesler merged commit 7fbda62 into main Oct 1, 2024
25 of 27 checks passed
@cdriesler cdriesler deleted the gergo/web-1926-test-app-api branch October 1, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants