chore(server): core IoC 18 - updateCommitAndNotifyFactory #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdriesler
approved these changes
Oct 7, 2024
| @@ -86,3 +91,23 @@ export type InsertStreamCommits = ( | |||
| trx: Knex.Transaction | |||
| }> | |||
| ) => Promise<number[]> | |||
|
|
|||
| export type UpdateCommitAndNotify = ( | |||
There was a problem hiding this comment.
strictly speaking, userId lives in params since it's not optional? but I say we do it later since it matches existing callers
There was a problem hiding this comment.
@cdriesler generally we want to avoid refactoring anything in these PRs, unless if there's a lot of value for minimum effort (e.g. deleting old code or typescriptifying)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References