Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): move common middleware to factory functions #3178

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore(auth): move common middleware to factory functions #3178

merged 1 commit into from
Oct 2, 2024

Conversation

cdriesler
Copy link
Member

Description & motivation

  • Workspace SSO login would like to re-use existing steps/middleware of our auth flow
  • They are currently only available in the auth module

Changes:

  • Exports middleware as factory functions
  • Uses them in existing strategy builder, and in step required by SSO

@cdriesler cdriesler merged commit 5110648 into main Oct 2, 2024
23 of 25 checks passed
@cdriesler cdriesler deleted the charles/authMiddleware branch October 2, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdriesler @fabis94