Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView Highlight Fix #3187

Merged
merged 2 commits into from
Oct 7, 2024
Merged

TreeView Highlight Fix #3187

merged 2 commits into from
Oct 7, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Fixes https://linear.app/speckle/issue/WEB-1958/visibility-issues-when-highlighting

Changes:

  • The highlight extension gets it's material cache reset when applying other filters by using the same approach as for selection

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

linear bot commented Oct 7, 2024

Copy link
Contributor

github-actions bot commented Oct 7, 2024

📸 Preview service has generated an image.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

📸 Preview service has generated an image.

@andrewwallacespeckle andrewwallacespeckle merged commit 4bcf3cc into main Oct 7, 2024
25 of 27 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the alex/WEB-1958 branch October 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants