fix(fe2): Border issues around invite banners #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewwallacespeckle
commented
Oct 9, 2024
•
andrewwallacespeckle
commented
- Removed divide-y which was causing the unnecessary line between invites
- ProjectInviteBanner and WorkspaceInvitesBanner are 2 separate components. This causes a weird visual bug, where both have rounded borders, but there is no gap. I added a small gap to make this seem more intentional.
@benjaminvo The second part was out of scope of this ticket, so just want to run this past you before merging.
benjaminvo
approved these changes
Oct 9, 2024
andrewwallacespeckle
deleted the
andrew/web-1973-border-issue-below-join-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.