Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sso): do not use authorize resolver for sso sign in #3443

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix(sso): do not use authorize resolver for sso sign in #3443

merged 2 commits into from
Nov 8, 2024

Conversation

cdriesler
Copy link
Member

@cdriesler cdriesler commented Nov 5, 2024 •
edited
Loading

Description & motivation

  • We recently changed authorizeResolver to throw in SSO workspaces if the user did not have a session
  • It was used, semi-lazily, in the SSO auth flow
  • So, it threw every time during sign in, if the user was signing in for the first time

Changes:

  • Replace authorizeResolver usage with more specific getWorkspaceRoles (we are just checking if user in in workspace)

@cdriesler cdriesler requested a review from gjedlicska November 5, 2024 22:46
@cdriesler cdriesler requested a review from alemagio November 8, 2024 10:59
@cdriesler cdriesler merged commit f716d0c into main Nov 8, 2024
25 of 27 checks passed
@cdriesler cdriesler deleted the charles/ssoAuthFix branch November 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemagio alemagio alemagio approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdriesler @alemagio