Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add cancel billing sessions, billing alerts, assume no plan is trial plan #3467

Merged
merged 8 commits into from
Nov 16, 2024
Merged

Feat: Add cancel billing sessions, billing alerts, assume no plan is trial plan #3467

merged 8 commits into from
Nov 16, 2024

Conversation

Mikehrn
Copy link
Contributor

@Mikehrn Mikehrn commented Nov 8, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Nov 8, 2024

WEB-2055 Cancel checkout session

@Mikehrn Mikehrn changed the title Feat: Cancel check session if URL has params Feat: Add cancel billing sessions, billing alerts, assume no plan is trial plan Nov 11, 2024
andrewwallacespeckle
andrewwallacespeckle reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good here, apart from the 1 comment I left.

I'm not sure how to best test this, I got the fe and server env vars added, but still wasn't able to pull through prices, I think down to the lack of stripe api key. Will sync with you on this.

packages/frontend-2/components/settings/workspaces/Billing.vue Outdated Show resolved Hide resolved
@Mikehrn Mikehrn merged commit 423350e into main Nov 16, 2024
25 of 27 checks passed
@Mikehrn Mikehrn deleted the mike/web-2055-cancel-checkout-session branch November 16, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwallacespeckle andrewwallacespeckle andrewwallacespeckle approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikehrn @andrewwallacespeckle