Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(automate): fix possible auth error #3470

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

cdriesler
Copy link
Member

Description & motivation

  • Deep diving into automate auth for ongoing work, appear to have caught a bug
  • The final part of the handshake - where automate asks speckle server if the auth code is real and valid:
    • Correctly checks if the code exists at all
    • Appears to be incorrectly asserting specific claims (user id, action) against itself, instead of the code automate has

Changes:

  • Validate stored auth code against incoming auth code from automate server, instead of itself (appears to be the intent of the code)

@iainsproat
Copy link
Contributor

No need to publish a security bulletin to advise self-servers to upgrade, as they could not enable Automate and this code anyway.

@cdriesler cdriesler merged commit e4a005f into main Nov 8, 2024
25 of 27 checks passed
@cdriesler cdriesler deleted the charles/automateAuthFix branch November 8, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants