Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(error): improve error log message for not found project id #3507

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 18, 2024

Description & motivation

The previous error message was confusing when uploading file, as Stream inputs are malformed could have possibly referred to the nodejs file stream.

This PR uses the new terminology in the log message, referring to projects instead of streams. It also includes the projectId in the error content, to enable inspection of the parsed project ID.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review November 18, 2024 14:33
@cdriesler cdriesler self-requested a review November 18, 2024 16:26
@iainsproat iainsproat merged commit 4e7a002 into main Nov 18, 2024
26 of 28 checks passed
@iainsproat iainsproat deleted the iain/improve-project-id-not-found-error-message branch November 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants