Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): add delays in test pubsub cleanup #3522

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Nov 20, 2024

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

)
await wait(500)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can play with these values around after, lets just get it working first

@iainsproat
Copy link
Contributor

Can we force kill it? https://stackoverflow.com/a/62878718
Or poll it's activity status until it's complete?

@fabis94 fabis94 merged commit 6c9b834 into main Nov 20, 2024
26 of 28 checks passed
@fabis94 fabis94 deleted the fabians/multiregion-test-flakiness2 branch November 20, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants