Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/logging): use structured message template not string formatting at runtime #3619

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Dec 3, 2024

  • string formatting causes high cardinality of messages in the logging system, which makes it difficult to group and filter them.

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat changed the title fix(server/logging): use structured message template not string forma… fix(server/logging): use structured message template not string formatting at runtime Dec 3, 2024
@iainsproat iainsproat marked this pull request as ready for review December 3, 2024 15:46
@iainsproat iainsproat requested a review from fabis94 December 3, 2024 15:46
@iainsproat iainsproat merged commit a0d2831 into main Dec 3, 2024
26 of 28 checks passed
@iainsproat iainsproat deleted the iain/fix-logging-previews-module branch December 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants