Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workspaces): no default discovery #3622

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix(workspaces): no default discovery #3622

merged 3 commits into from
Dec 3, 2024

Conversation

cdriesler
Copy link
Member

Description & motivation

  • With paid workspaces, we want to add friction/intention behind adding seats. The current "discoverable workspaces" feature turns on by default, which was fine when access was free, but we'd like it to be on purpose now.

Changes:

  • Do not enable domain discovery by default when adding a domain

Mikehrn
Mikehrn approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Mikehrn Mikehrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE part looks good niffo

@cdriesler cdriesler merged commit 101a0b2 into main Dec 3, 2024
26 of 28 checks passed
@cdriesler cdriesler deleted the charles/noDefaultDiscovery branch December 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikehrn Mikehrn Mikehrn approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

@andrewwallacespeckle andrewwallacespeckle Awaiting requested review from andrewwallacespeckle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdriesler @Mikehrn