Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(automate): cascade delete automations with projects #3627

Merged
merged 3 commits into from
Dec 4, 2024
Merged

fix(automate): cascade delete automations with projects #3627

merged 3 commits into from
Dec 4, 2024

Conversation

cdriesler
Copy link
Member

Description & motivation

  • Projects with automations couldn't be deleted because of fk constraints
  • It was not enough to mark automationRevisionId as a cascade delete because of its use in a composite primary key

Changes:

  • Migrate automation_revision_functions to have its own id
  • Populate it randomly so we don't have to think about it / change repo access
  • Add automation count in delete dialog, as a treat

@cdriesler cdriesler requested a review from gjedlicska December 4, 2024 12:06
@cdriesler cdriesler requested a review from fabis94 December 4, 2024 14:16
@cdriesler cdriesler merged commit ce3941c into main Dec 4, 2024
26 of 28 checks passed
@cdriesler cdriesler deleted the charles/deleteAutomationsWithWorkspaces branch December 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdriesler @fabis94