Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): allow using frontend proxy in fe2 mode too #3658

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat(server): allow using frontend proxy in fe2 mode too #3658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/server/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ export async function shutdown(params: {
}

const shouldUseFrontendProxy = () =>
process.env.NODE_ENV === 'development' && process.env.USE_FRONTEND_2 !== 'true'
process.env.NODE_ENV === 'development' && process.env.USE_FRONTEND_PROXY === 'true'

async function createFrontendProxy() {
const frontendHost = process.env.FRONTEND_HOST || '127.0.0.1'
Expand Down Expand Up @@ -535,7 +535,7 @@ export async function startHttp(params: {
// app.use('/', frontendProxy)
app.use(await createFrontendProxy())

startupLogger.info('✨ Proxying frontend-1 (dev mode):')
startupLogger.info('✨ Proxying frontend (dev mode):')
startupLogger.info(`👉 main application: http://127.0.0.1:${port}/`)
}

Expand Down