Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): correct type in notifications helper #3694

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix(server): correct type in notifications helper #3694

merged 3 commits into from
Dec 16, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Dec 13, 2024 •
edited
Loading

Description & motivation

Same fix as #3687, seems to have been a consistent error in the codebase.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review December 13, 2024 14:25
@iainsproat iainsproat merged commit 3b67a51 into main Dec 16, 2024
26 of 28 checks passed
@iainsproat iainsproat deleted the iain/fix-types-notificationsHelper branch December 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alemagio alemagio alemagio approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iainsproat @alemagio