Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Unable to delete project from workspace settings #3708

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Fix: Unable to delete project from workspace settings #3708

merged 8 commits into from
Dec 18, 2024

Conversation

Mikehrn
Copy link
Contributor

@Mikehrn Mikehrn commented Dec 17, 2024 •
edited
Loading

Unifies both existing project delete modals into one, fix the deletion not possible bug

@linear Linear
Copy link

linear bot commented Dec 17, 2024

WEB-2347 Unable to delete project from Workspace Settings

andrewwallacespeckle
andrewwallacespeckle previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't pull this and run it, but the code looks good

@Mikehrn Mikehrn merged commit 29bcb66 into main Dec 18, 2024
26 of 28 checks passed
@Mikehrn Mikehrn deleted the mike/web-2347-unable-to-delete-project-from-workspace-settings branch December 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwallacespeckle andrewwallacespeckle andrewwallacespeckle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikehrn @andrewwallacespeckle