Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimitrie/cnx 430 re evaluate parameters #255

Merged
merged 17 commits into from
Sep 23, 2024

Conversation

didimitrie
Copy link
Member

@didimitrie didimitrie commented Sep 18, 2024

CNX-430: Re-evaluate parameters

Introduces a new data layout for parameters. They're now stored under properties, and generally make things 3x more compact.

Copy link

linear bot commented Sep 18, 2024

@didimitrie didimitrie marked this pull request as ready for review September 23, 2024 09:13
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 1.53846% with 128 lines in your changes missing coverage. Please review.

Project coverage is 7.81%. Comparing base (33bf136) to head (ce3b0e7).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...tShared/ToSpeckle/Parameters/ParameterExtractor.cs 0.00% 72 Missing and 1 partial ⚠️
...ToSpeckle/Parameters/ParameterDefinitionHandler.cs 0.00% 28 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 20 Missing ⚠️
...ters.RevitShared/Extensions/ParameterExtensions.cs 0.00% 4 Missing ⚠️
...tShared/Settings/RevitConversionSettingsFactory.cs 0.00% 1 Missing ⚠️
...tShared/ToSpeckle/Raw/ColumnConversionToSpeckle.cs 0.00% 1 Missing ⚠️
...hared/ToSpeckle/Raw/MaterialConversionToSpeckle.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #255      +/-   ##
========================================
- Coverage   7.86%   7.81%   -0.05%     
========================================
  Files        235     236       +1     
  Lines       4477    4518      +41     
  Branches     523     543      +20     
========================================
+ Hits         352     353       +1     
- Misses      4110    4149      +39     
- Partials      15      16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral force-pushed the dimitrie/cnx-430-re-evaluate-parameters branch 2 times, most recently from 005d405 to 9a43d5d Compare September 23, 2024 16:10
@oguzhankoral oguzhankoral enabled auto-merge (squash) September 23, 2024 16:33
@oguzhankoral oguzhankoral merged commit 6d3eb88 into dev Sep 23, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the dimitrie/cnx-430-re-evaluate-parameters branch September 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants