Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed esri targets file #261

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fixed esri targets file #261

merged 1 commit into from
Sep 19, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Sep 19, 2024

Last time I updated the esri file, I had to remove some references to nugets.
This fixed build, but clean was still broken

I thought that this was because of the commenting out I'd done.
Turns out, @AlanRynne has better eyes than I, and found that the clean build has its own references that can be commented out, which fixes clean and rebuilds.

Sorry @KatKatKateryna, this has been an annoyance for both of us, and an easy fix. Thanks @AlanRynne! 🙌

@JR-Morgan JR-Morgan requested a review from AlanRynne September 19, 2024 13:46
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.86%. Comparing base (cb78f42) to head (f48fc01).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #261   +/-   ##
=====================================
  Coverage   7.86%   7.86%           
=====================================
  Files        235     235           
  Lines       4477    4477           
  Branches     523     523           
=====================================
  Hits         352     352           
  Misses      4110    4110           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan enabled auto-merge (squash) September 19, 2024 13:50
@JR-Morgan JR-Morgan merged commit 6deb59e into dev Sep 19, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the jrm/esri-clean branch September 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants