Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending worksetId and workset name + groups named after full path #275

Merged

Conversation

kekesidavid
Copy link
Contributor

Sending worksetId and worksetName with element
Naming groups after full collection path
Fixes CNX-94
Fixes CNX-542

@kekesidavid kekesidavid merged commit 0950202 into dev Sep 24, 2024
3 checks passed
@kekesidavid kekesidavid deleted the david/cnx-94-exr-109-revit-include-workset-name-alongside-id branch September 24, 2024 16:03
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 8.44%. Comparing base (3227d09) to head (f14623a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #275      +/-   ##
========================================
- Coverage   8.46%   8.44%   -0.02%     
========================================
  Files        236     236              
  Lines       4549    4558       +9     
  Branches     548     549       +1     
========================================
  Hits         385     385              
- Misses      4147    4156       +9     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants