Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ConversionNotSupportedException instead of system one #279

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

AlanRynne
Copy link
Member

Within conversions, we should be returning "ConversionNotSupportedException" instead of the system "NotSupportedException".

Copy link

linear bot commented Sep 25, 2024

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.46%. Comparing base (f59a374) to head (a0f3052).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #279   +/-   ##
=====================================
  Coverage   8.46%   8.46%           
=====================================
  Files        229     229           
  Lines       4546    4546           
  Branches     553     553           
=====================================
  Hits         385     385           
  Misses      4144    4144           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanRynne AlanRynne enabled auto-merge (squash) September 25, 2024 09:20
@AlanRynne AlanRynne merged commit d8f3fa7 into dev Sep 25, 2024
5 checks passed
@AlanRynne AlanRynne deleted the alan/CNX-457-fix-acad-conversion-logging branch September 25, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants