feat(civil): adds basic element converter and fixes DI #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure-civil-commits-by-prospector
adamhathcock
approved these changes
Oct 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #292 +/- ##
=====================================
Coverage 8.38% 8.38%
=====================================
Files 231 231
Lines 4589 4589
Branches 565 565
=====================================
Hits 385 385
Misses 4187 4187
Partials 17 17 ☔ View full report in Codecov by Sentry. |
AlanRynne
approved these changes
Oct 9, 2024
AlanRynne
deleted the
claire/cnx-586-restructure-civil-commits-by-prospector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DI and registration for Civil3d, since the change from using
contexttosettings.Includes a new top level generic civil entity converter.
CivilRootToHostConverterso root objects can be built differently than in autocad and a newCivilSendBindingdue to the need for different settings registration (incl a newCivilSettingsFactoryin the converter)