-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimitrie/cnx 510 revit parameter exports perfection #300
Dimitrie/cnx 510 revit parameter exports perfection #300
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #300 +/- ##
========================================
- Coverage 8.72% 8.67% -0.05%
========================================
Files 232 232
Lines 4641 4666 +25
Branches 542 551 +9
========================================
Hits 405 405
- Misses 4219 4244 +25
Partials 17 17 ☔ View full report in Codecov by Sentry. |
(extracting material thickness and composition)
tbh, this just makes it easier to show in the frontend - but worthwhile for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine to me. Approving, but the object
type for the param name dictionary took a bit to understand: passing a tuple in the case of ElementType
to be parsed later - more comments wouldn't hurt here
Fixes a bunch of tickets from revit parameters.