Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimitrie/cnx 510 revit parameter exports perfection #300

Merged
merged 10 commits into from
Oct 12, 2024

Conversation

didimitrie
Copy link
Member

Fixes a bunch of tickets from revit parameters.

Copy link

linear bot commented Oct 11, 2024

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 8.67%. Comparing base (188f23f) to head (1e53700).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...tShared/ToSpeckle/Parameters/ParameterExtractor.cs 0.00% 34 Missing ⚠️
...hared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs 0.00% 2 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #300      +/-   ##
========================================
- Coverage   8.72%   8.67%   -0.05%     
========================================
  Files        232     232              
  Lines       4641    4666      +25     
  Branches     542     551       +9     
========================================
  Hits         405     405              
- Misses      4219    4244      +25     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

(extracting material thickness and composition)
tbh, this just makes it easier to show in the frontend - but worthwhile for now
@didimitrie didimitrie marked this pull request as ready for review October 11, 2024 13:14
@didimitrie didimitrie enabled auto-merge October 11, 2024 13:15
Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine to me. Approving, but the object type for the param name dictionary took a bit to understand: passing a tuple in the case of ElementType to be parsed later - more comments wouldn't hurt here

@didimitrie didimitrie merged commit 0a27fc1 into dev Oct 12, 2024
5 checks passed
@didimitrie didimitrie deleted the dimitrie/cnx-510-revit-parameter-exports-perfection branch October 12, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants