Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(civil3d/rhino): adds correct curves to displayvalue and receiving arcs as fallback in rhino #326

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Oct 24, 2024

Fixes issue in receiving Civil3d elements with curves in their display value in rhino.
This was done by:

  • prefiltering list of ICurve in Civil3d to only include lines, polylines, and arcs to be used as display values.
  • adding arcs to the supported types of fallback geometry in rhino
  • IMPORTANT! changes all converter resolution to recursive = true by default

sample commit: https://latest.speckle.systems/projects/3f895e614f/models/1737754fb4@1d2b032ba5

received in rhino:
{589AE953-792B-480C-B158-47E66C07B06B}

extra check received in autocad:
{3C905819-DC10-4CBA-872D-F0D7FDB23134}

…s arcs to supported fallback curves in rhino
Copy link

linear bot commented Oct 24, 2024

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.39%. Comparing base (a14b0a6) to head (0720b17).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ToHost/TopLevel/FallbackToHostTopLevelConverter.cs 0.00% 3 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #326      +/-   ##
========================================
- Coverage   8.40%   8.39%   -0.01%     
========================================
  Files        240     240              
  Lines       4832    4835       +3     
  Branches     561     562       +1     
========================================
  Hits         406     406              
- Misses      4409    4412       +3     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recursive = true 😬

@clairekuang clairekuang merged commit af7bc47 into dev Oct 25, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-684-civil2rhino-receive-problems branch October 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants