refactor(objects): cnx 687 purge unused classes from objects

[clairekuang]

Changes to all converters pending this pr in sdk: specklesystems/speckle-sharp-sdk#151 . To be merged after SDK pr is merged.

• removes qgis backwards compatibility and revit/rhino parameters and user strings in arcgis
• removes unused parameter, material, and material quantities code in revit
• refactors revit modelcurves by sending them as regular geometry instead

[linear]

CNX-687 Purge unused classes from Objects

[KatKatKateryna]

Checked ArcGIS part - looks good except the Parameters converter, it will look nearly the same for Dictionary object and can be reused for that.

[KatKatKateryna]

we can just move this part of code lower to the condition "if Dict" rather than if Base. Why removing if the TODO is already done here?

[clairekuang]

Let's sync on this: archicad, civil3d, revit, and eventually tekla will send some properties/parameters under the properties field with a dict value - need to implement this in a way in arcgis that can handle diff levels of nesting

[codecov]

Codecov Report

Attention: Patch coverage is 12.12121% with 29 lines in your changes missing coverage. Please review.

Project coverage is 8.48%. Comparing base (8cfe0bf) to head (ae08faa).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
...Speckle/TopLevel/RoomTopLevelConverterToSpeckle.cs	0.00%	13 Missing ⚠️
.../TopLevel/DirectShapeTopLevelConverterToSpeckle.cs	0.00%	4 Missing ⚠️
...opLevel/FootPrintRoofToSpeckleTopLevelConverter.cs	0.00%	2 Missing ⚠️
...e/TopLevel/ModelCurveToSpeckleTopLevelConverter.cs	0.00%	2 Missing ⚠️
...RhinoShared/ToSpeckle/Raw/BoxToSpeckleConverter.cs	0.00%	2 Missing ⚠️
...itShared/ToHost/Raw/Geometry/ArcConverterToHost.cs	0.00%	1 Missing ⚠️
...e/Raw/Geometry/BoundingBoxXYZToSpeckleConverter.cs	0.00%	1 Missing ⚠️
...ToSpeckle/Raw/Geometry/CircleToSpeckleConverter.cs	0.00%	1 Missing ⚠️
...ckle/TopLevel/CeilingTopLevelConverterToSpeckle.cs	0.00%	1 Missing ⚠️
...noShared/ToSpeckle/Raw/CircleToSpeckleConverter.cs	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@           Coverage Diff            @@
##             dev    #333      +/-   ##
========================================
+ Coverage   8.40%   8.48%   +0.08%     
========================================
  Files        240     237       -3     
  Lines       4829    4641     -188     
  Branches     561     514      -47     
========================================
- Hits         406     394      -12     
+ Misses      4406    4231     -175     
+ Partials      17      16       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adamhathcock]

Works for me