Revit async fix for sending

Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Send/RevitRootObjectBuilder.cs

@@ -56,6 +56,13 @@ public async Task<RootObjectBuilderResult> Build(
     SendInfo sendInfo,
     IProgress<CardProgress> onOperationProgressed,
     CancellationToken ct = default
+  ) => await RevitTask.RunAsync(() => BuildSync(objects, sendInfo, onOperationProgressed, ct)).ConfigureAwait(false);
+
+  private RootObjectBuilderResult BuildSync(
+    IReadOnlyList<ElementId> objects,
+    SendInfo sendInfo,
+    IProgress<CardProgress> onOperationProgressed,
+    CancellationToken ct = default
   )
   {
     var doc = _converterSettings.Current.Document;
@@ -110,7 +117,7 @@ public async Task<RootObjectBuilderResult> Build(
         }
         else
         {
-          converted = await RevitTask.RunAsync(() => _converter.Convert(revitElement)).ConfigureAwait(false); // Could we run these batched? Is there maybe a performance penalty for running these to speckle conversions individually in revittask.runasync?
+          converted = _converter.Convert(revitElement);
           converted.applicationId = applicationId;
         }
 

Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Parameters/ParameterDefinitionHandler.cs

@@ -37,11 +37,8 @@ definition is DB.InternalDefinition internalDefinition
       internalDefinitionName = internalDefinition.BuiltInParameter.ToString();
     }
 
-#pragma warning disable CA1854 // swapping leads to nullability errors; should be resolved once we type this more strongly.
-    if (Definitions.ContainsKey(internalDefinitionName))
-#pragma warning restore CA1854
+    if (Definitions.TryGetValue(internalDefinitionName, out var def))
     {
-      var def = Definitions[internalDefinitionName];
       return (
         internalDefinitionName,
         humanReadableName,

Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs

@@ -31,7 +31,7 @@ IConverterSettingsStore<RevitConversionSettings> converterSettings
   public Dictionary<string, object> Convert(DB.Element target)
   {
     Dictionary<string, object> quantities = new();
-    if (target.Category.HasMaterialQuantities)
+    if (target.Category?.HasMaterialQuantities ?? false) //category can be null
     {
       foreach (DB.ElementId matId in target.GetMaterialIds(false))
       {