Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscriminatedObjectConverter needs DI #363

Merged
merged 8 commits into from
Nov 22, 2024
Merged

DiscriminatedObjectConverter needs DI #363

merged 8 commits into from
Nov 22, 2024

Conversation

adamhathcock
Copy link
Member

No description provided.

@adamhathcock adamhathcock enabled auto-merge (squash) November 21, 2024 15:52
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 8.37%. Comparing base (2211428) to head (e44c054).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...nectors.DUI/Utils/JsonSerializerSettingsFactory.cs 0.00% 20 Missing ⚠️
...3/Speckle.Connectors.DUI/Bindings/ConfigBinding.cs 0.00% 6 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs 0.00% 6 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Utils/JsonSerializer.cs 0.00% 5 Missing ⚠️
...peckle.Connectors.DUI/Models/DocumentModelStore.cs 0.00% 4 Missing ⚠️
...nnectors.DUI/Utils/DiscriminatedObjectConverter.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #363      +/-   ##
========================================
- Coverage   8.37%   8.37%   -0.01%     
========================================
  Files        237     239       +2     
  Lines       4704    4707       +3     
  Branches     514     509       -5     
========================================
  Hits         394     394              
- Misses      4294    4297       +3     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@adamhathcock adamhathcock merged commit abcf58d into dev Nov 22, 2024
5 checks passed
@adamhathcock adamhathcock deleted the oguz-di-issue branch November 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants