Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Revit): Optimised Revit parameter extraction #365

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

JR-Morgan
Copy link
Member

Optimised parameter extraction by avoiding duplicated calls to expensive API queries

Disabled attaching parameter definitions to root object (requested by Dim)

Optimised displayValue extraction by removing surface area checking

@JR-Morgan JR-Morgan enabled auto-merge (squash) November 7, 2024 11:57
@JR-Morgan JR-Morgan changed the title Jrm/parameter extraction perf(Revit): Optimised Revit parameter extraction Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 8.40%. Comparing base (dd53b70) to head (22ef45f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ToSpeckle/Parameters/ParameterDefinitionHandler.cs 0.00% 11 Missing ⚠️
...tShared/ToSpeckle/Parameters/ParameterExtractor.cs 0.00% 6 Missing ⚠️
...rters.RevitShared/Helpers/DisplayValueExtractor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #365      +/-   ##
========================================
- Coverage   8.40%   8.40%   -0.01%     
========================================
  Files        238     238              
  Lines       4688    4690       +2     
  Branches     514     510       -4     
========================================
  Hits         394     394              
- Misses      4278    4280       +2     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan merged commit 6ba70a7 into dev Nov 7, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the jrm/parameter-extraction branch November 7, 2024 12:03
jsdbroughton added a commit that referenced this pull request Nov 8, 2024
* dev:
  Fixed autocad async (#370)
  chore: comments
  fix: allows pre-transformation of all ITransformable objects
  adds a setting to send rebars as line or solid (#367)
  Update SDK and dependencies (#366)
  Jrm/parameter extraction (#365)
  dogukan/cnx-753-normals-are-flipped (#364)
  Dogukan/cnx 691 extract appropriate class properties by type (#352)
  Revit async fix for sending (#362)
  feat: adds top level converter for railings
  dogukan/cnx-748-send-grids-from-tekla (#353)
  fix: adds built in category for setting ds cat on receive reliably
  feat: CXPLA-120 Added tekla zip packaging prior to installers (#357)
  add appId (#358)
  adds logic for rendering rebars as lines and arcs (#356)
  Fixed test failing on german culture (#355)
  CNX-501 Temp folder arcgis (#351)
  receive operation fix (#350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants